> On May 31, 2019, 11:48 p.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java > > Lines 633 (patched) > > <https://reviews.apache.org/r/70759/diff/4/?file=2147506#file2147506line635> > > > > impalaDDL => hiveDDL
done > On May 31, 2019, 11:48 p.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java > > Lines 646 (patched) > > <https://reviews.apache.org/r/70759/diff/4/?file=2147506#file2147506line648> > > > > add the corresponding entry in BaseHiveEvent to set serviceType to > > "hive" for hiveDDL entities done > On May 31, 2019, 11:48 p.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java > > Lines 109 (patched) > > <https://reviews.apache.org/r/70759/diff/4/?file=2147507#file2147507line109> > > > > createImpalaDDLEntity => createHiveDDLEntity done > On May 31, 2019, 11:48 p.m., Sarath Subramanian wrote: > > addons/models/0000-Area0/0010-base_model.json > > Lines 88 (patched) > > <https://reviews.apache.org/r/70759/diff/4/?file=2147512#file2147512line88> > > > > 'serviceType' attribute is not defined here, value set in > > impalaDDL.setAttribute(ATTRIBUTE_SERVICE_TYPE, "impala"); will not be > > assigned to anything. added > On May 31, 2019, 11:48 p.m., Sarath Subramanian wrote: > > addons/models/1000-Hadoop/1030-hive_model.json > > Line 572 (original), 538 (patched) > > <https://reviews.apache.org/r/70759/diff/4/?file=2147513#file2147513line572> > > > > you don't need `db_ddl` as supertype, can consider adding supertype - > > "ddl" and remove types - db_ddl and table_ddl. done > On May 31, 2019, 11:48 p.m., Sarath Subramanian wrote: > > addons/models/1000-Hadoop/1030-hive_model.json > > Line 581 (original), 547 (patched) > > <https://reviews.apache.org/r/70759/diff/4/?file=2147513#file2147513line581> > > > > you don't need `table_ddl` as supertype, can consider adding supertype > > - "ddl" done > On May 31, 2019, 11:48 p.m., Sarath Subramanian wrote: > > addons/models/1000-Hadoop/1030-hive_model.json > > Line 727 (original), 693 (patched) > > <https://reviews.apache.org/r/70759/diff/4/?file=2147513#file2147513line727> > > > > type should still be "hive_table_ddl" done > On May 31, 2019, 11:48 p.m., Sarath Subramanian wrote: > > addons/models/1000-Hadoop/1030-hive_model.json > > Line 746 (original), 712 (patched) > > <https://reviews.apache.org/r/70759/diff/4/?file=2147513#file2147513line746> > > > > type should still be "hive_db_ddl" done - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/#review215629 ----------------------------------------------------------- On May 31, 2019, 11:24 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70759/ > ----------------------------------------------------------- > > (Updated May 31, 2019, 11:24 p.m.) > > > Review request for atlas, madhan and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > ATLAS-3197 introduced a new feature on Hive integration. It introduced new > model called Hive_table_ddl and hive_db_ddl which are used to track commands > that are executed either on a table entity or bd entity. DDL entities will be > added to a table/db entity through relationshipAttribute call HIVE_DB_TO_DDL > and hive_tb_to_ddl. Every time when a new command is executed, a new ddl > entity will be created, it will append to the existing ddlQueries field if a > table/db has already been created. Once a table/db is deleted, all these > relationship attributes will be deleted as well. > > We need to support this new feature on Impala integration. > > > Diffs > ----- > > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java > d241b6a > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java > b7506a4 > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/model/ImpalaDataType.java > 10ce448 > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageITBase.java > b8cbf6b > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java > 7f9a534 > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookIT.java > 6156208 > addons/models/0000-Area0/0010-base_model.json d14b227 > addons/models/1000-Hadoop/1030-hive_model.json 417c4c5 > > > Diff: https://reviews.apache.org/r/70759/diff/4/ > > > Testing > ------- > > add check for ddl entities in integration tests > > > Thanks, > > Na Li > >
