----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70840/#review215835 -----------------------------------------------------------
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java Lines 181 (patched) <https://reviews.apache.org/r/70840/#comment302772> Consider using a try/finally. repository/src/main/java/org/apache/atlas/services/MetricsService.java Lines 149 (patched) <https://reviews.apache.org/r/70840/#comment302771> Is this commit() needed here, as the caller, getMetrics(), is annotated with @GraphTransaction? repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java Lines 163 (patched) <https://reviews.apache.org/r/70840/#comment302770> is @GraphTransaction annotation needed here, as commit() is explicitly called in #171 and #177? repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java Lines 185 (patched) <https://reviews.apache.org/r/70840/#comment302769> is @GraphTransaction annotation needed here, as commit() is explicitly called in #195 and #201? - Madhan Neethiraj On June 12, 2019, 8:14 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70840/ > ----------------------------------------------------------- > > (Updated June 12, 2019, 8:14 a.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, > and Madhan Neethiraj. > > > Bugs: ATLAS-3276 > https://issues.apache.org/jira/browse/ATLAS-3276 > > > Repository: atlas > > > Description > ------- > > Fix stale transactions in atlas due to ATLAS-3246 > > > Diffs > ----- > > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java > 4b441bf6d > repository/src/main/java/org/apache/atlas/services/MetricsService.java > 8fb68e926 > repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java > 0c86aff2c > > > Diff: https://reviews.apache.org/r/70840/diff/1/ > > > Testing > ------- > > No longer see stale transaction alerts in atlas logs. > > Precommit: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1199/console > > > Thanks, > > Sarath Subramanian > >
