> On June 12, 2019, 1:13 p.m., Madhan Neethiraj wrote: > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java > > Line 382 (original), 388 (patched) > > <https://reviews.apache.org/r/70840/diff/2/?file=2149252#file2149252line389> > > > > Consider using try/finally here as well - similar to #195. > > > > Same for line #372 as well.
did not want to use try/finally here, since try block might not have multiple exits/exceptions. but added anyways. - Sarath ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70840/#review215856 ----------------------------------------------------------- On June 12, 2019, 2:04 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70840/ > ----------------------------------------------------------- > > (Updated June 12, 2019, 2:04 p.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, > and Madhan Neethiraj. > > > Bugs: ATLAS-3276 > https://issues.apache.org/jira/browse/ATLAS-3276 > > > Repository: atlas > > > Description > ------- > > Fix stale transactions in atlas due to ATLAS-3246 > > > Diffs > ----- > > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java > 4dd641da7 > repository/src/main/java/org/apache/atlas/services/MetricsService.java > 8fb68e926 > repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java > 0c86aff2c > > > Diff: https://reviews.apache.org/r/70840/diff/3/ > > > Testing > ------- > > No longer see stale transaction alerts in atlas logs. > > Precommit: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1199/console > > > Thanks, > > Sarath Subramanian > >
