----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71056/#review216542 -----------------------------------------------------------
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java Lines 357 (patched) <https://reviews.apache.org/r/71056/#comment303753> Instead of using pathInstList and tableInstList, consider rewriting #355 - #360 as below: processInst.setRelationshipAttribute(ATTRIBUTE_INPUTS, Collections.singletonList(getObjectIdWithRelationshipType(pathInst, RELATIONSHIP_DATASET_PROCESS_INPUTS))); processInst.setRelationshipAttribute(ATTRIBUTE_OUTPUTS, Collections.singletonList(getObjectIdWithRelationshipType(tableInst, RELATIONSHIP_PROCESS_DATASET_OUTPUTS))); addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java Lines 587 (patched) <https://reviews.apache.org/r/71056/#comment303754> for simpler reading, consider replacing #586, #587 with: tableEntity.setRelationshipAttribute(ATTRIBUTE_DB, getObjectIdWithRelationshipType(database, RELATIONSHIP_HIVE_TABLE_DB)); Same for #639 and #697 - Madhan Neethiraj On July 11, 2019, 1:24 p.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71056/ > ----------------------------------------------------------- > > (Updated July 11, 2019, 1:24 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3325 > https://issues.apache.org/jira/browse/ATLAS-3325 > > > Repository: atlas > > > Description > ------- > > ATLAS-3325 Update hive-bridge to use relationship attributes > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java > 5f8f846 > > > Diff: https://reviews.apache.org/r/71056/diff/1/ > > > Testing > ------- > > Steps done for updating > 1. Disable hive-hook from Ambari. > 2. Create table in hive. > 3. Check whether table entity is created in Atlas side or not.(It should not > be created) > 4. Run script import-hive.sh > 5. Check again in Atlas side, hive table and DB entities are created with > relationship. > > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1255/console > > > Thanks, > > Mandar Ambawane > >
