-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71056/#review216576
-----------------------------------------------------------


Fix it, then Ship it!





addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
Lines 41 (patched)
<https://reviews.apache.org/r/71056/#comment303784>

    nit: unused import; consider removing it.



addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
Line 630 (original), 631 (patched)
<https://reviews.apache.org/r/71056/#comment303786>

    toStroageDescEntity => toStorageDescEntity



addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
Line 211 (original), 211 (patched)
<https://reviews.apache.org/r/71056/#comment303783>

    refactor this method to:
    
    return getObjectIdWithRelationshipType(getObjectId(entity), 
relationshipType);



addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
Lines 214 (patched)
<https://reviews.apache.org/r/71056/#comment303781>

    getObjectIdWithRelationshipType => getAtlasRelatedObjectId; same for line 
209
    
    relationShipType => relationshipType; same for line# 209


- Sarath Subramanian


On July 12, 2019, 3:55 a.m., Mandar Ambawane wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71056/
> -----------------------------------------------------------
> 
> (Updated July 12, 2019, 3:55 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3325
>     https://issues.apache.org/jira/browse/ATLAS-3325
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-3325 Update hive-bridge to use relationship attributes
> 
> 
> Diffs
> -----
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  5f8f846 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
>  b3663da 
> 
> 
> Diff: https://reviews.apache.org/r/71056/diff/2/
> 
> 
> Testing
> -------
> 
> Steps done for updating 
> 1. Disable hive-hook from Ambari.
> 2. Create table in hive.
> 3. Check whether table entity is created in Atlas side or not.(It should not 
> be created) 
> 4. Run script import-hive.sh
> 5. Check again in Atlas side, hive table and DB entities are created with 
> relationship. 
> 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1255/console
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Reply via email to