-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71253/#review217123
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Lines 248 (patched)
<https://reviews.apache.org/r/71253/#comment304384>

    Extract to method. Call it say, processEntitiesToSkip.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Lines 250 (patched)
<https://reviews.apache.org/r/71253/#comment304387>

    Consider reworking this to something more efficient.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Lines 253 (patched)
<https://reviews.apache.org/r/71253/#comment304386>

    Way this is used it may be better to store entitiesToSkip in a map of guids.



server-api/src/main/java/org/apache/atlas/RequestContext.java
Lines 347 (patched)
<https://reviews.apache.org/r/71253/#comment304385>

    What is the purpose of this method?


- Ashutosh Mestry


On Aug. 8, 2019, 1:51 p.m., Saqeeb Shaikh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71253/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2019, 1:51 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3360
>     https://issues.apache.org/jira/browse/ATLAS-3360
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Entity audits in atlas are getting duplicated when both HMS hook and Hive 
> hook are enabled.
> 
> 
> Diffs
> -----
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  983d4fa 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  f9010fe 
>   server-api/src/main/java/org/apache/atlas/RequestContext.java 62899b6 
> 
> 
> Diff: https://reviews.apache.org/r/71253/diff/1/
> 
> 
> Testing
> -------
> 
> Created new hive table - create table test_tab1(t_col1 string);
> Alter hive table to add new column - alter table test_tab1 add columns(t_col2 
> string);
> Drop hive table - drop table test_tab1;
> 
> 
> Thanks,
> 
> Saqeeb Shaikh
> 
>

Reply via email to