----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71253/#review217174 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Lines 251 (patched) <https://reviews.apache.org/r/71253/#comment304447> we don't need to maintain 'entityHeaderMap'. For each element in entitiesToSkip (line#254), we can convert the entity to entityHeader and check for contains operation. Please review. - Sarath Subramanian On Aug. 8, 2019, 6:51 a.m., Saqeeb Shaikh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71253/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2019, 6:51 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3360 > https://issues.apache.org/jira/browse/ATLAS-3360 > > > Repository: atlas > > > Description > ------- > > Entity audits in atlas are getting duplicated when both HMS hook and Hive > hook are enabled. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > 983d4fa > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > f9010fe > server-api/src/main/java/org/apache/atlas/RequestContext.java 62899b6 > > > Diff: https://reviews.apache.org/r/71253/diff/1/ > > > Testing > ------- > > Created new hive table - create table test_tab1(t_col1 string); > Alter hive table to add new column - alter table test_tab1 add columns(t_col2 > string); > Drop hive table - drop table test_tab1; > > > Thanks, > > Saqeeb Shaikh > >
