----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71406/#review217525 -----------------------------------------------------------
Fix it, then Ship it! server-api/src/main/java/org/apache/atlas/RequestContext.java Lines 364 (patched) <https://reviews.apache.org/r/71406/#comment304785> Is it necessary to handle 'null' as a special value here? Caller of getForwardedAddresses() will have to deal with null return anyway, since setForwardedAddresses() need not be called. I suggest to simply set this.forwardedAddresses to the given value. - Madhan Neethiraj On Aug. 29, 2019, 1:31 p.m., Nikhil Bonte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71406/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2019, 1:31 p.m.) > > > Review request for atlas, madhan, Nixon Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-3387 > https://issues.apache.org/jira/browse/ATLAS-3387 > > > Repository: atlas > > > Description > ------- > > Consider X-FORWARDED-FOR header for getting end user IP address when > connected with proxy > > > Diffs > ----- > > > authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java > b031f4c3e > > authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java > ac2f52525 > server-api/src/main/java/org/apache/atlas/RequestContext.java d518609d3 > webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java > 54f7330da > > > Diff: https://reviews.apache.org/r/71406/diff/5/ > > > Testing > ------- > > Tested with simple authorizer. Need to test after ranger end changes. > > > Thanks, > > Nikhil Bonte > >
