----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71406/#review217596 -----------------------------------------------------------
authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java Lines 104 (patched) <https://reviews.apache.org/r/71406/#comment304868> Lines #104, #105 should be added for other AccessRequest types as well, for example at: #83, #130, #155, #180 - Madhan Neethiraj On Sept. 5, 2019, 10:23 a.m., Nikhil Bonte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71406/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2019, 10:23 a.m.) > > > Review request for atlas, madhan, Nixon Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-3387 > https://issues.apache.org/jira/browse/ATLAS-3387 > > > Repository: atlas > > > Description > ------- > > Consider X-FORWARDED-FOR header for getting end user IP address when > connected with proxy > > > Diffs > ----- > > > authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java > b031f4c3e > > authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java > ac2f52525 > server-api/src/main/java/org/apache/atlas/RequestContext.java d518609d3 > webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java > 54f7330da > > > Diff: https://reviews.apache.org/r/71406/diff/6/ > > > Testing > ------- > > Tested with simple authorizer. Need to test after ranger end changes. > > > Thanks, > > Nikhil Bonte > >
