----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71431/#review217738 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java Line 50 (original), 57 (patched) <https://reviews.apache.org/r/71431/#comment305100> ClassificationSearchProcessor needs to be updated as well to support sortBy. Please review and update. repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java Lines 205 (patched) <https://reviews.apache.org/r/71431/#comment305098> graphQuery requires 'qualifiedName' of the attribute (i.e. Asset.name, Asset.owner) - refer to SearchProcessor.toGraphFilterQuery(). Is 'sortBy' here qualifiedName of the attribute? repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java Lines 233 (patched) <https://reviews.apache.org/r/71431/#comment305087> Is line #233 needed? Please review. repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java Lines 287 (patched) <https://reviews.apache.org/r/71431/#comment305096> lines #275 - #288 can be executed before entering the 'for' loop at #263; consider moving these lines to #254. - Madhan Neethiraj On Sept. 14, 2019, 12:45 p.m., Bolke de Bruin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71431/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2019, 12:45 p.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, > Madhan Neethiraj, and Nixon Rodrigues. > > > Bugs: https://issues.apache.org/jira/browse/ATLAS-3399 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3399 > > > Repository: atlas > > > Description > ------- > > Add indexed order by to basic search. > > > Diffs > ----- > > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java > f3722b827 > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusIndexQuery.java > 7c258b7a3 > graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java > e457866af > intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java > aac6b5aa3 > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > f7d8f08c7 > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java e6b338b84 > webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java > 06931b38c > webapp/src/test/resources/json/search-parameters/entity-filters.json > f4b2efe63 > > > Diff: https://reviews.apache.org/r/71431/diff/2/ > > > Testing > ------- > > - production and tests added > > > Thanks, > > Bolke de Bruin > >
