----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71431/#review217764 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/SearchContext.java Lines 272 (patched) <https://reviews.apache.org/r/71431/#comment305137> Instead of creating FilterCriteria, consider using lines #263 - #265 here: if (StringUtils.isNotEmpty(attributeName) && structType.getAttributeType(attributeName) == null) { throw new AtlasBaseException(AtlasErrorCode.UNKNOWN_ATTRIBUTE, attributeName, structType.getTypeName()); Better yet, update 'else' block at #260 to call this method: } else { validateAttribute(structType, filterCriteria.getAttributeName(); } - Madhan Neethiraj On Sept. 16, 2019, 7:03 p.m., Bolke de Bruin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71431/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2019, 7:03 p.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, > Madhan Neethiraj, and Nixon Rodrigues. > > > Bugs: https://issues.apache.org/jira/browse/ATLAS-3399 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3399 > > > Repository: atlas > > > Description > ------- > > Add indexed order by to basic search. > > > Diffs > ----- > > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java > f3722b827 > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusIndexQuery.java > 7c258b7a3 > graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java > e457866af > intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java > aac6b5aa3 > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 479ddfd89 > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > f7d8f08c7 > repository/src/main/java/org/apache/atlas/discovery/SearchContext.java > 9bd0382eb > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java e6b338b84 > webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java > 06931b38c > webapp/src/test/resources/json/search-parameters/entity-filters.json > f4b2efe63 > webapp/src/test/resources/json/search-parameters/tag-filters.json 5e74328d6 > > > Diff: https://reviews.apache.org/r/71431/diff/5/ > > > Testing > ------- > > - production and tests added > > > Thanks, > > Bolke de Bruin > >
