----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71564/#review218007 -----------------------------------------------------------
Fix it, then Ship it! intg/src/main/java/org/apache/atlas/AtlasErrorCode.java Lines 158 (patched) <https://reviews.apache.org/r/71564/#comment305468> Is it necessary to specify "1 to 50" in this error message? Perhaps there should be 2 messages - one for incorrect contents and another for invalid length? intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java Lines 64 (patched) <https://reviews.apache.org/r/71564/#comment305470> Is customAttributes needed in AtlasEntityHeader? repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java Lines 1069 (patched) <https://reviews.apache.org/r/71564/#comment305471> Consider initializing 'ret' to 'null' here. repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Lines 822 (patched) <https://reviews.apache.org/r/71564/#comment305472> Consider using Objects.equals() - to handle null values. - Madhan Neethiraj On Oct. 1, 2019, 6:44 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71564/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2019, 6:44 a.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, > Madhan Neethiraj, and Nixon Rodrigues. > > > Bugs: ATLAS-3431 > https://issues.apache.org/jira/browse/ATLAS-3431 > > > Repository: atlas > > > Description > ------- > > A data steward would like to be able to store arbitrary key-value pair data > on any entity in Atlas so they can enrich and annotate instances with > additional context. > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java 2f08efce0 > intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 916052482 > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 9a1aa65f6 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java > 67493baab > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java > 3aef6cd7f > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > 981cfc7d8 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 3cc91a586 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > 0d3d82a11 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > db658639f > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > c921130f6 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java > a4edaf086 > > > Diff: https://reviews.apache.org/r/71564/diff/1/ > > > Testing > ------- > > Added new unit-tests: AtlasEntityStoreV2Test > > validated in REST-client > > Precommit: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1444/ > > > Thanks, > > Sarath Subramanian > >
