----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71564/#review218014 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Lines 1170 (patched) <https://reviews.apache.org/r/71564/#comment305477> If 'AtlasBaseException' is not thrown from this method, consider removing 'throws' from the signature. repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Lines 2195 (patched) <https://reviews.apache.org/r/71564/#comment305478> Consider using Pattern.matches(), instead of String.matches(): // line #116 Pattern CUSTOM_ATTRIBUTE_KEY_REGEX = Pattern.compile("^[a-zA-Z0-9_-]*$"); // line #2195 Matcher matcher = CUSTOM_ATTRIBUTE_KEY_REGEX.matcher(key); if (!matcher.matches(key)) { throw new AtlasBaseException(AtlasErrorCode.INVALID_CUSTOM_ATTRIBUTE_KEY_CHARACTERS, key); } - Madhan Neethiraj On Oct. 2, 2019, 5:04 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71564/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2019, 5:04 a.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, > Madhan Neethiraj, and Nixon Rodrigues. > > > Bugs: ATLAS-3431 > https://issues.apache.org/jira/browse/ATLAS-3431 > > > Repository: atlas > > > Description > ------- > > A data steward would like to be able to store arbitrary key-value pair data > on any entity in Atlas so they can enrich and annotate instances with > additional context. > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java 2f08efce0 > intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 916052482 > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 9a1aa65f6 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java > 67493baab > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > 981cfc7d8 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 3cc91a586 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java > 5de2d7c51 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > 607adc059 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 495d7883c > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > c921130f6 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java > a4edaf086 > > > Diff: https://reviews.apache.org/r/71564/diff/3/ > > > Testing > ------- > > Added new unit-tests: AtlasEntityStoreV2Test > > validated in REST-client > > Precommit: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1444/ > > > Thanks, > > Sarath Subramanian > >
