----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71736/#review218665 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java Line 403 (original), 405 (patched) <https://reviews.apache.org/r/71736/#comment306520> AtlasAttribute ret = getAttribute(attrName); intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java Line 57 (original), 57 (patched) <https://reviews.apache.org/r/71736/#comment306521> adding 'throws AtlasBaseException' to an existing methods (at #57, #68) can break current calls of this method; consider callers outside Atlas repo. resolveReferences() on ENTITY_ROOT and CLASSIFICATION_ROOT should not result in exceptions. I suggest to handle any exception here as a RuntimeException, so that the method signature doesn't need to be updated. try { AtlasEntityType.ENTITY_ROOT.resolveReferences(this); AtlasClassificationType.CLASSIFICATION_ROOT.resolveReferences(this); } catch (AtlasBaseException excp) { LOG.error("failed to initialize root types", excp); throw new RuntimeException(excp); } After this update, most the test code changes in this patch can be reverted. Please review and update. repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java Line 55 (original), 57 (patched) <https://reviews.apache.org/r/71736/#comment306523> this condition may not be necessary: "StringUtils.isNotEmpty(context.getEntityType().getTypeName()) &&" webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java Line 330 (original), 330 (patched) <https://reviews.apache.org/r/71736/#comment306522> "parameters.getEntityFilters() == null" => !isEmpty(parameters.getEntityFilters()) "parameters.getTagFilters() == null" => !isEmpty(parameters.getTagFilters()) - Madhan Neethiraj On Nov. 18, 2019, 10:30 p.m., Le Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71736/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2019, 10:30 p.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan > Neethiraj, and Sarath Subramanian. > > > Bugs: ATLAS-3482 > https://issues.apache.org/jira/browse/ATLAS-3482 > > > Repository: atlas > > > Description > ------- > > Introduce ALL_ENTITY_TYPE to support search on system attributes across all > entity types. System attributes will be passed in as normal entity attributes. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java > 8f0e5912d > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > e10965b87 > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > 417194202 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 884447f81 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java e8bf7f9eb > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 8b4fd1c3b > intg/src/main/java/org/apache/atlas/type/Constants.java PRE-CREATION > intg/src/test/java/org/apache/atlas/TestUtilsV2.java 530d5cda4 > > intg/src/test/java/org/apache/atlas/entitytransform/TransformationHandlerTest.java > d3f4b57ad > intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java 5df952546 > intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 742970390 > intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java > 107539598 > intg/src/test/java/org/apache/atlas/type/TestAtlasTypeRegistry.java > 476bc3300 > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 672f38132 > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > 03eb92bcc > > repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java > 152ade8d4 > repository/src/main/java/org/apache/atlas/discovery/SearchContext.java > 7ad32bdb9 > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > b56d8e83a > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 825cda30b > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java > cd8f8981c > > > Diff: https://reviews.apache.org/r/71736/diff/4/ > > > Testing > ------- > > - Added new unit tests, passed. > - pre-commit job succeeds. > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1540/ > > > Thanks, > > Le Ma > >
