> On Nov. 19, 2019, 9:20 a.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/discovery/SearchContext.java > > Line 59 (original), 61 (patched) > > <https://reviews.apache.org/r/71736/diff/4/?file=2173823#file2173823line61> > > > > avoid unnecessary whitespace/newline changes > > > > line 61-75 > > line 83-90
Hello Sarath, thanks for reviewing the code. I've reverted the changes for #83 - #90. The change for line 61 - 75 is to make variables with same scope together for readability. I suggest we keep it. Thanks. - Le ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71736/#review218667 ----------------------------------------------------------- On Nov. 19, 2019, 8:04 p.m., Le Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71736/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2019, 8:04 p.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan > Neethiraj, and Sarath Subramanian. > > > Bugs: ATLAS-3482 > https://issues.apache.org/jira/browse/ATLAS-3482 > > > Repository: atlas > > > Description > ------- > > Introduce ALL_ENTITY_TYPE to support search on system attributes across all > entity types. System attributes will be passed in as normal entity attributes. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java > 8f0e5912d > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > e10965b87 > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > 417194202 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 884447f81 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java e8bf7f9eb > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 8b4fd1c3b > intg/src/main/java/org/apache/atlas/type/Constants.java PRE-CREATION > intg/src/test/java/org/apache/atlas/TestUtilsV2.java 530d5cda4 > intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java > 107539598 > intg/src/test/java/org/apache/atlas/type/TestAtlasTypeRegistry.java > 476bc3300 > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 672f38132 > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > 03eb92bcc > > repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java > 152ade8d4 > repository/src/main/java/org/apache/atlas/discovery/SearchContext.java > 7ad32bdb9 > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > b56d8e83a > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 825cda30b > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java > cd8f8981c > > > Diff: https://reviews.apache.org/r/71736/diff/5/ > > > Testing > ------- > > - Added new unit tests, passed. > - pre-commit job succeeds. > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1540/ > > > Thanks, > > Le Ma > >
