----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71922/#review219215 -----------------------------------------------------------
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json Lines 15 (patched) <https://reviews.apache.org/r/71922/#comment307336> Rename: aws_s3_v2_contained (since containee does not exist in english language) addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json Lines 20 (patched) <https://reviews.apache.org/r/71922/#comment307339> Should contain ownerId. addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json Lines 21 (patched) <https://reviews.apache.org/r/71922/#comment307346> Add bucketName, since all objects have it. addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json Lines 23 (patched) <https://reviews.apache.org/r/71922/#comment307337> Considering adding: bucketName. addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json Lines 24 (patched) <https://reviews.apache.org/r/71922/#comment307338> Consider adding: encryption addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json Lines 58 (patched) <https://reviews.apache.org/r/71922/#comment307345> Should be moved to base class. Since every s3 object has this. addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json Lines 102 (patched) <https://reviews.apache.org/r/71922/#comment307340> Rename: aws_s3_v2_directory addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json Lines 111 (patched) <https://reviews.apache.org/r/71922/#comment307341> Consider adding: Region addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json Lines 121 (patched) <https://reviews.apache.org/r/71922/#comment307342> What is the purpose of this? addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json Lines 129 (patched) <https://reviews.apache.org/r/71922/#comment307343> What is the purpose of this? addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json Lines 137 (patched) <https://reviews.apache.org/r/71922/#comment307344> Rename: currentStorageLocation to location. addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json Lines 168 (patched) <https://reviews.apache.org/r/71922/#comment307347> Need not be indexable. addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json Lines 190 (patched) <https://reviews.apache.org/r/71922/#comment307348> What is the purpose of this? addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json Lines 214 (patched) <https://reviews.apache.org/r/71922/#comment307349> I think this attribute is at object level. addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json Lines 222 (patched) <https://reviews.apache.org/r/71922/#comment307350> This is at object level. addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json Lines 238 (patched) <https://reviews.apache.org/r/71922/#comment307351> This should be part of base class. - Ashutosh Mestry On Jan. 8, 2020, 11:12 p.m., Sidharth Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71922/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2020, 11:12 p.m.) > > > Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and > Sarath Subramanian. > > > Bugs: ATLAS-3564 > https://issues.apache.org/jira/browse/ATLAS-3564 > > > Repository: atlas > > > Description > ------- > > This is the new version) of aws s3 model at atlas to allow the hierarchical > structure and attributes same as AWS S3 Console. The existing aws s3 models > has limitations like pseudo directory not containing another pseudo > directory, pseudo directory doesn't have attributes of aws object (as some > case it gets populated), both object and bucket doesn't containing all the > attributes of AWS S3 etc. > > > Diffs > ----- > > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/71922/diff/3/ > > > Testing > ------- > > > Thanks, > > Sidharth Mishra > >
