> On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote: > > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json > > Lines 15 (patched) > > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line15> > > > > Rename: aws_s3_v2_contained (since containee does not exist in english > > language)
What will be relationship name - aws_s3_v2_container_contained? > On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote: > > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json > > Lines 20 (patched) > > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line20> > > > > Should contain ownerId. We have OwnerName which will be usefull for Atlas. Do you think OwnerId like f9fca4893bbb1d52d88edbcf22a42cc5b81c29496c8b881fc160faab93c73945 which is specific to aws it worth adding to atals model? > On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote: > > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json > > Lines 21 (patched) > > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line21> > > > > Add bucketName, since all objects have it. The qualified name in each object will have bucketName. Should we add another item for it. That will be redundant. > On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote: > > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json > > Lines 23 (patched) > > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line23> > > > > Considering adding: bucketName. same as above. > On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote: > > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json > > Lines 58 (patched) > > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line58> > > > > Should be moved to base class. Since every s3 object has this. This is the object base type and directory is derived from this > On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote: > > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json > > Lines 111 (patched) > > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line111> > > > > Consider adding: Region The qualified name in each object will have Region as well. Should we add another item for it. That will be redundant. > On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote: > > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json > > Lines 121 (patched) > > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line121> > > > > What is the purpose of this? This is being added for backward compatibility i.e. if we can eventually move from older version to new one completely. > On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote: > > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json > > Lines 129 (patched) > > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line129> > > > > What is the purpose of this? same as above > On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote: > > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json > > Lines 137 (patched) > > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line137> > > > > Rename: currentStorageLocation to location. rename to storageLocation as only location may be confusing with path or key. Please suggest. > On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote: > > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json > > Lines 190 (patched) > > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line190> > > > > What is the purpose of this? This is being added for backward compatibility i.e. if we can eventually move from older version to new one completely. > On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote: > > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json > > Lines 214 (patched) > > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line214> > > > > I think this attribute is at object level. I have removed isEncrypted. > On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote: > > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json > > Lines 222 (patched) > > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line222> > > > > This is at object level. Bucket is not derived from object and thats the reason we have this at both the places. Only this and tag is common property among object and bucket. Do you think extracting these two to another basetype will make sense? > On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote: > > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json > > Lines 238 (patched) > > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line238> > > > > This should be part of base class. same as above. - Sidharth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71922/#review219215 ----------------------------------------------------------- On Jan. 8, 2020, 11:12 p.m., Sidharth Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71922/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2020, 11:12 p.m.) > > > Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and > Sarath Subramanian. > > > Bugs: ATLAS-3564 > https://issues.apache.org/jira/browse/ATLAS-3564 > > > Repository: atlas > > > Description > ------- > > This is the new version) of aws s3 model at atlas to allow the hierarchical > structure and attributes same as AWS S3 Console. The existing aws s3 models > has limitations like pseudo directory not containing another pseudo > directory, pseudo directory doesn't have attributes of aws object (as some > case it gets populated), both object and bucket doesn't containing all the > attributes of AWS S3 etc. > > > Diffs > ----- > > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/71922/diff/3/ > > > Testing > ------- > > > Thanks, > > Sidharth Mishra > >
