----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72172/#review219683 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Lines 1504 (patched) <https://reviews.apache.org/r/72172/#comment307896> Instead of adding isValidLength() to AtlasType, I suggest to add this to AtlasNamespaceAttribute - since maxLength is valid only for namespace attributes. - Madhan Neethiraj On Feb. 27, 2020, 6:51 p.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72172/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2020, 6:51 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3632 > https://issues.apache.org/jira/browse/ATLAS-3632 > > > Repository: atlas > > > Description > ------- > > Added check for length limit of String value > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java ed1e5de > intg/src/main/java/org/apache/atlas/type/AtlasType.java b30b483 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > 30f5e5a > > > Diff: https://reviews.apache.org/r/72172/diff/1/ > > > Testing > ------- > > > Thanks, > > Mandar Ambawane > >
