----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72172/#review219765 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Line 49 (original), 49 (patched) <https://reviews.apache.org/r/72172/#comment307965> Please avoid collapse/expand changes to existing 'import' statements. repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Lines 1501 (patched) <https://reviews.apache.org/r/72172/#comment307964> Please add unit tests to exercise both valid and invalid length cases. - Madhan Neethiraj On March 4, 2020, 12:29 p.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72172/ > ----------------------------------------------------------- > > (Updated March 4, 2020, 12:29 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3632 > https://issues.apache.org/jira/browse/ATLAS-3632 > > > Repository: atlas > > > Description > ------- > > Added check for length limit of String value > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java ede8443 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > 30f5e5a > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2Test.java > e2f5c16 > > > Diff: https://reviews.apache.org/r/72172/diff/3/ > > > Testing > ------- > > Pre-commit build: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1698/console > > Manul testing done by adding values beyong maximum length for String > namespace attributes. > Done same for String multi-valued namespace attributes. > > > Thanks, > > Mandar Ambawane > >
