Can this be merged please? Sent from my iPhone
Begin forwarded message: > From: Bolke de Bruin <[email protected]> > Date: 26 March 2020 at 14:38:51 CET > To: Madhan Neethiraj <[email protected]>, Sarath Subramanian > <[email protected]>, Ashutosh Mestry <[email protected]>, Nixon Rodrigues > <[email protected]>, Bolke de Bruin <[email protected]> > Cc: atlas <[email protected]>, Mariusz Górski > <[email protected]> > Subject: Re: Review Request 72104: ATLAS-3610 Enable logging to STDOUT in > Atlas startup scripts > Reply-To: Bolke de Bruin <[email protected]> > > > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72104/ > > Ship it! > > Ship It! > > - Bolke de Bruin > > > On March 26th, 2020, 7:41 a.m. UTC, Mariusz Górski wrote: > > Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, > Nixon Rodrigues, and Sarath Subramanian. > By Mariusz Górski. > Updated March 26, 2020, 7:41 a.m. > > Repository: atlas > Description > > This patch enables logging to STDOUT from processes spawned through > atlas_start.py or atlas_config.py scripts. For now, even if configured in > log4j, logging to STDOUT was supressed (by redirecting to log files only). > Testing > > The tests were concluded by: > > Building & running Atlas locally with default log4j configuration and > -Dlog.console mvn build option set to true. > Building & running Atlas on Openshift with log4j configuration pushing > everything to STDOUT and -Dlog.console mvn build option set to true. > Running distro tests on localhost > > In both scenarios logs were available both in the .out/.err files in the > Atlas logdir (backwards compatibility), but at the same time I was able to > see them in STDOUT of both running process (local installation) and pod > (openshift deployment). > Diffs > > distro/pom.xml (7159b16cf) > distro/src/bin/atlas_config.py (f09026ff9) > distro/src/bin/atlas_start.py (963faf402) > distro/src/bin/cputil.py (98a9dc36d) > distro/src/conf/atlas-env.sh (c4241e665) > distro/src/test/python/scripts/TestMetadata.py (f1235f747) > View Diff
