----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72351/#review220287 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java Lines 231 (patched) <https://reviews.apache.org/r/72351/#comment308618> caching => limit repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java Lines 418 (patched) <https://reviews.apache.org/r/72351/#comment308619> - I suggest to replace use of DEFAULT_CACHING with explicit 'maxResults' parameter to this method - similar to #403 above - given this method returns EntityAuditEventV2 objects, consider changing the return type from List<Object> to List<EntityAuditEventV2> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java Lines 611 (patched) <https://reviews.apache.org/r/72351/#comment308615> guid => auditGuid, to avoid confusing with 'guid' of entity (for which the audit record was generated). webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java Lines 623 (patched) <https://reviews.apache.org/r/72351/#comment308616> Consider avoiding prefix 'atlas' for variables. atlasAuditEntry => auditEntry webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java Lines 624 (patched) <https://reviews.apache.org/r/72351/#comment308617> Consider handling atlasAuditEntry.getResult() == null - Madhan Neethiraj On April 10, 2020, 10:44 p.m., Sidharth Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72351/ > ----------------------------------------------------------- > > (Updated April 10, 2020, 10:44 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-3727 > https://issues.apache.org/jira/browse/ATLAS-3727 > > > Repository: atlas > > > Description > ------- > > ATLAS-3727: Add get result details REST for admin audit record > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java > 98e56f2bb > > repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java > 35bf1d07e > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java > cab4e1e55 > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditRepository.java > 2a47e39ed > > repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java > 021ca43ab > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 2ab8bdb03 > webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java > 43b85efc0 > > > Diff: https://reviews.apache.org/r/72351/diff/1/ > > > Testing > ------- > > Manual Testing: > > curl -u admin:admin123 --location --request GET > 'http://sid-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/admin/audit/706e6e32-b619-43f2-8587-f2877ee27582/details?limit=100&offset=0' > --header 'Content-Type: application/json' > > > Thanks, > > Sidharth Mishra > >
