> On April 11, 2020, 1:35 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java > > Lines 231 (patched) > > <https://reviews.apache.org/r/72351/diff/1/?file=2217432#file2217432line231> > > > > caching => limit
I think this parameter is causing confusion and its been used for scan.setCaching(MAXPAYLOAD) which will increase the payload size to MAXPAYLOAD rows per remote call. I am removing this from function parameter as this will be always to a const value. - Sidharth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72351/#review220287 ----------------------------------------------------------- On April 13, 2020, 6:15 p.m., Sidharth Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72351/ > ----------------------------------------------------------- > > (Updated April 13, 2020, 6:15 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-3727 > https://issues.apache.org/jira/browse/ATLAS-3727 > > > Repository: atlas > > > Description > ------- > > ATLAS-3727: Add get result details REST for admin audit record > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java > 98e56f2bb > intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java > bcfdd9466 > > repository/src/main/java/org/apache/atlas/repository/audit/AbstractStorageBasedAuditRepository.java > 0deb7295e > > repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java > 35bf1d07e > > repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java > b8131bd39 > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java > 4c1e1a959 > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditRepository.java > 2a47e39ed > > repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java > 021ca43ab > > repository/src/main/java/org/apache/atlas/repository/audit/InMemoryEntityAuditRepository.java > ad6ec94c0 > > repository/src/main/java/org/apache/atlas/repository/audit/NoopEntityAuditRepository.java > 4bb68d502 > > repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java > aa175a229 > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 2ab8bdb03 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 402a323dd > webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java > 43b85efc0 > > > Diff: https://reviews.apache.org/r/72351/diff/2/ > > > Testing > ------- > > Manual Testing: > > curl -u admin:admin123 --location --request GET > 'http://sid-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/admin/audit/706e6e32-b619-43f2-8587-f2877ee27582/details?limit=100&offset=0' > --header 'Content-Type: application/json' > > > Thanks, > > Sidharth Mishra > >