-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72614/#review221055
-----------------------------------------------------------




addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 5 (patched)
<https://reviews.apache.org/r/72614/#comment309839>

    If each instance of this struct represent one location, consider renaming 
keyLocations => keyLocation.



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 88 (patched)
<https://reviews.apache.org/r/72614/#comment309840>

    Consider using an enum for storageType - if the list of values is 
well-known in Ozone.



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 96 (patched)
<https://reviews.apache.org/r/72614/#comment309841>

    versioning => supportsVersioning/versioningEnabled



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 137 (patched)
<https://reviews.apache.org/r/72614/#comment309842>

    Consider using an enum for replicationType - if the list of values is 
well-known in Ozone.



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 169 (patched)
<https://reviews.apache.org/r/72614/#comment309843>

    Given Atlas may not track all updates to Ozone objects, I suggest to not 
have 'modificationTime' attribute in the model.



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 181 (patched)
<https://reviews.apache.org/r/72614/#comment309838>

    ozone_volume_ozone_bucket => ozone_volume_buckets



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 185 (patched)
<https://reviews.apache.org/r/72614/#comment309833>

    I suggest to not specify explicit 'relationshipLabel' here; this is 
necessary only for earlier version entity-types that didn't use relationships.



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 188 (patched)
<https://reviews.apache.org/r/72614/#comment309834>

    bucket => buckets



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 201 (patched)
<https://reviews.apache.org/r/72614/#comment309837>

    ozone_bucket_ozone_key => ozone_bucket_keys



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 205 (patched)
<https://reviews.apache.org/r/72614/#comment309835>

    I suggest to not specify explicit 'relationshipLabel' here; this is 
necessary only for earlier version entity-types that didn't use relationships.



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 208 (patched)
<https://reviews.apache.org/r/72614/#comment309836>

    key => keys


- Madhan Neethiraj


On June 23, 2020, 5:45 a.m., Nikhil Bonte wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72614/
> -----------------------------------------------------------
> 
> (Updated June 23, 2020, 5:45 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
> Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3856
>     https://issues.apache.org/jira/browse/ATLAS-3856
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Add following ozone typeDefs to Atlas models
> 
>     Ozone volume
>     Ozone bucket
>     Ozone key
> 
> 
> Diffs
> -----
> 
>   addons/models/3000-Cloud/3050-ozone-typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72614/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nikhil Bonte
> 
>

Reply via email to