-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72614/#review221057
-----------------------------------------------------------




addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 6 (patched)
<https://reviews.apache.org/r/72614/#comment309852>

    "Atlas Type representing the locations for key" => "location information 
about Ozone key"



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 15 (patched)
<https://reviews.apache.org/r/72614/#comment309853>

    "isOptional" is set to false for all attributes of "keyLocations". Can 
there be cases where you don't have all the information and only some.



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 22 (patched)
<https://reviews.apache.org/r/72614/#comment309850>

    consider setting "isIndexable" to true for all string, int and date type 
attributes. This will enable searching on this attributes using basic search.



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 28 (patched)
<https://reviews.apache.org/r/72614/#comment309851>

    does "length" type needs to be of string type?



addons/models/3000-Cloud/3050-ozone-typedefs.json
Lines 49 (patched)
<https://reviews.apache.org/r/72614/#comment309854>

    ozone => Ozone


- Sarath Subramanian


On June 22, 2020, 10:45 p.m., Nikhil Bonte wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72614/
> -----------------------------------------------------------
> 
> (Updated June 22, 2020, 10:45 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
> Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3856
>     https://issues.apache.org/jira/browse/ATLAS-3856
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Add following ozone typeDefs to Atlas models
> 
>     Ozone volume
>     Ozone bucket
>     Ozone key
> 
> 
> Diffs
> -----
> 
>   addons/models/3000-Cloud/3050-ozone-typedefs.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72614/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nikhil Bonte
> 
>

Reply via email to