----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/#review221297 -----------------------------------------------------------
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java Lines 260 (patched) <https://reviews.apache.org/r/72695/#comment310175> Consistency lock might be relevant/needed only for unique-index i.e. isUnique=true. If this true, consider calling setConsistency(LOCK) when isUnique is true, without requiring additional argument. Same applies for #278 as well. It will be useful support following configuration, to optionally disable consistentcy-lock: atlas.graph.storage.unique-key.consitency-lock.enabled This configuration can be sent to AtlasJanusGraphManagement during construction - from AtlasJanusGraph.getManagementSystem(). Above will avoid updates to many methods for the addition of lockEnabled argument. - Madhan Neethiraj On July 20, 2020, 9:48 p.m., Damian Warszawski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72695/ > ----------------------------------------------------------- > > (Updated July 20, 2020, 9:48 p.m.) > > > Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and Sarath > Subramanian. > > > Repository: atlas > > > Description > ------- > > Optional configuration to support locks on JanusGraph to ensure data > consitency. > > JanusGraph is eventually consistent by default which is efficient but results > in duplicates when race condition occurs. > > > Reference to jira > https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-3398 > > > Diffs > ----- > > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java > fca789027 > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java > 6ef9cb76c > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java > 35004157f > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java > 5cd55093e > intg/src/main/java/org/apache/atlas/ApplicationProperties.java e662c8fae > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > e35f3594f > > repository/src/main/java/org/apache/atlas/repository/patches/ConcurrentPatchProcessor.java > 5a9ac2abe > > repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatch.java > d3111f110 > > > Diff: https://reviews.apache.org/r/72695/diff/1/ > > > Testing > ------- > > Not possible to reproduce the error on local machine. Enable locking on our > dev env and have not introduce any regression. > > > Thanks, > > Damian Warszawski > >
