> On July 21, 2020, 9:06 p.m., Madhan Neethiraj wrote: > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java > > Lines 260 (patched) > > <https://reviews.apache.org/r/72695/diff/1/?file=2236033#file2236033line260> > > > > Consistency lock might be relevant/needed only for unique-index i.e. > > isUnique=true. If this true, consider calling setConsistency(LOCK) when > > isUnique is true, without requiring additional argument. Same applies for > > #278 as well. > > > > It will be useful support following configuration, to optionally > > disable consistentcy-lock: > > atlas.graph.storage.unique-key.consitency-lock.enabled > > > > This configuration can be sent to AtlasJanusGraphManagement during > > construction - from AtlasJanusGraph.getManagementSystem(). > > > > Above will avoid updates to many methods for the addition of > > lockEnabled argument.
Great suggestion. Changed accordingly. Thanks. - Damian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/#review221297 ----------------------------------------------------------- On July 24, 2020, 8:23 a.m., Damian Warszawski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72695/ > ----------------------------------------------------------- > > (Updated July 24, 2020, 8:23 a.m.) > > > Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and Sarath > Subramanian. > > > Repository: atlas > > > Description > ------- > > Optional configuration to support locks on JanusGraph to ensure data > consitency. > > JanusGraph is eventually consistent by default which is efficient but results > in duplicates when race condition occurs. > > > Reference to jira > https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-3398 > > > Diffs > ----- > > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java > 6ef9cb76c > intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 2c007ca01 > > > Diff: https://reviews.apache.org/r/72695/diff/2/ > > > Testing > ------- > > Not possible to reproduce the error on local machine. Enable locking on our > dev env and have not introduce any regression. > > > Thanks, > > Damian Warszawski > >
