----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72730/#review221546 -----------------------------------------------------------
atlas-examples/sample-app/src/main/python/discovery_example.py Lines 3 (patched) <https://reviews.apache.org/r/72730/#comment310609> Remove two extra blank lines. Along with this please add content to README.md file as well atlas-examples/sample-app/src/main/python/discovery_example.py Lines 12 (patched) <https://reviews.apache.org/r/72730/#comment310601> should we rename it to something more meaningful? atlas-examples/sample-app/src/main/python/utils.py Lines 11 (patched) <https://reviews.apache.org/r/72730/#comment310600> I think it will be good to rename these const to have some prefix like CUSTOM or SAMPLE to differentiate between the existing table types. client/client-v2/src/main/python/atlas_client/base_client.py Lines 84 (patched) <https://reviews.apache.org/r/72730/#comment310602> Should we have custom exceptions like AtlasException instead of Exception thrown from most of the python client similar to Java client. This will help the users of the client to handle appropriately and distinguish from the generic python exceptions client/client-v2/src/main/python/atlas_client/discovery_client.py Lines 6 (patched) <https://reviews.apache.org/r/72730/#comment310608> Remove one extra blank line client/client-v2/src/main/python/atlas_client/discovery_client.py Lines 20 (patched) <https://reviews.apache.org/r/72730/#comment310603> Can we have vertical indentation like: DSL_SEARCH = API(DSL_SEARCH_URI, HttpMethod.GET, HTTPStatus.OK) FULL_TEXT_SEARCH = API(FULL_TEXT_SEARCH_URI, HttpMethod.GET, HTTPStatus.OK) BASIC_SEARCH = API(BASIC_SEARCH_URI, HttpMethod.GET, HTTPStatus.OK) FACETED_SEARCH = API(FACETED_SEARCH_URI, HttpMethod.POST, HTTPStatus.OK) ATTRIBUTE_SEARCH = API(DISCOVERY_URI + "/attribute", HttpMethod.GET, HTTPStatus.OK) In case you are changing please take care of this at other places client/client-v2/src/main/python/atlas_client/discovery_model.py Lines 18 (patched) <https://reviews.apache.org/r/72730/#comment310606> Add blank line after the header comment. Please do at other files as well client/client-v2/src/main/python/atlas_client/discovery_model.py Lines 22 (patched) <https://reviews.apache.org/r/72730/#comment310604> Please remove one extra blank line (we always keep one blank line as separator if needed) client/client-v2/src/main/python/atlas_client/discovery_model.py Lines 145 (patched) <https://reviews.apache.org/r/72730/#comment310607> Please remove if not needed - Sidharth Mishra On Aug. 10, 2020, 5:26 p.m., Jyoti Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72730/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2020, 5:26 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3875 > https://issues.apache.org/jira/browse/ATLAS-3875 > > > Repository: atlas > > > Description > ------- > > - Added basic structure for Python client > - This includes all classes for Entity and TypeDef > - Added all endpoints for typedef > > > Diffs > ----- > > atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION > atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION > atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION > atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION > > atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json > PRE-CREATION > > atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json > PRE-CREATION > > atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json > PRE-CREATION > > atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json > PRE-CREATION > atlas-examples/sample-app/src/main/python/request_json/typedef_create.json > PRE-CREATION > atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION > atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION > atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION > client/client-v2/src/main/python/LICENSE PRE-CREATION > client/client-v2/src/main/python/README.md PRE-CREATION > client/client-v2/src/main/python/atlas_client/__init__.py PRE-CREATION > client/client-v2/src/main/python/atlas_client/base_client.py PRE-CREATION > client/client-v2/src/main/python/atlas_client/discovery_client.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/discovery_model.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/entity_client.py PRE-CREATION > client/client-v2/src/main/python/atlas_client/entity_model.py PRE-CREATION > client/client-v2/src/main/python/atlas_client/glossary_client.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/glossary_model.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/lineage_client.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/lineage_model.py PRE-CREATION > client/client-v2/src/main/python/atlas_client/relationship_client.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/relationship_model.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/typedef_client.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/typedef_model.py PRE-CREATION > client/client-v2/src/main/python/atlas_client/utils.py PRE-CREATION > client/client-v2/src/main/python/requirements.txt PRE-CREATION > client/client-v2/src/main/python/setup.py PRE-CREATION > client/client-v2/src/main/python/tests/__init__.py PRE-CREATION > client/client-v2/src/main/resources/logging.conf PRE-CREATION > > > Diff: https://reviews.apache.org/r/72730/diff/4/ > > > Testing > ------- > > Tested on local. > > > Thanks, > > Jyoti Singh > >
