> On Aug. 11, 2020, 6:50 p.m., Sidharth Mishra wrote: > > client/client-v2/src/main/python/atlas_client/discovery_model.py > > Lines 22 (patched) > > <https://reviews.apache.org/r/72730/diff/4/?file=2237707#file2237707line22> > > > > Please remove one extra blank line (we always keep one blank line as > > separator if needed)
For Python classes we have to add 2 blank lines between imports and class name. https://www.python.org/dev/peps/pep-0008/#blank-lines - Jyoti ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72730/#review221546 ----------------------------------------------------------- On Aug. 10, 2020, 5:26 p.m., Jyoti Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72730/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2020, 5:26 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3875 > https://issues.apache.org/jira/browse/ATLAS-3875 > > > Repository: atlas > > > Description > ------- > > - Added basic structure for Python client > - This includes all classes for Entity and TypeDef > - Added all endpoints for typedef > > > Diffs > ----- > > atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION > atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION > atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION > atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION > > atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json > PRE-CREATION > > atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json > PRE-CREATION > > atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json > PRE-CREATION > > atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json > PRE-CREATION > atlas-examples/sample-app/src/main/python/request_json/typedef_create.json > PRE-CREATION > atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION > atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION > atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION > client/client-v2/src/main/python/LICENSE PRE-CREATION > client/client-v2/src/main/python/README.md PRE-CREATION > client/client-v2/src/main/python/atlas_client/__init__.py PRE-CREATION > client/client-v2/src/main/python/atlas_client/base_client.py PRE-CREATION > client/client-v2/src/main/python/atlas_client/discovery_client.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/discovery_model.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/entity_client.py PRE-CREATION > client/client-v2/src/main/python/atlas_client/entity_model.py PRE-CREATION > client/client-v2/src/main/python/atlas_client/glossary_client.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/glossary_model.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/lineage_client.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/lineage_model.py PRE-CREATION > client/client-v2/src/main/python/atlas_client/relationship_client.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/relationship_model.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/typedef_client.py > PRE-CREATION > client/client-v2/src/main/python/atlas_client/typedef_model.py PRE-CREATION > client/client-v2/src/main/python/atlas_client/utils.py PRE-CREATION > client/client-v2/src/main/python/requirements.txt PRE-CREATION > client/client-v2/src/main/python/setup.py PRE-CREATION > client/client-v2/src/main/python/tests/__init__.py PRE-CREATION > client/client-v2/src/main/resources/logging.conf PRE-CREATION > > > Diff: https://reviews.apache.org/r/72730/diff/4/ > > > Testing > ------- > > Tested on local. > > > Thanks, > > Jyoti Singh > >
