----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72894/#review221940 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2.java Lines 75 (patched) <https://reviews.apache.org/r/72894/#comment311008> This will add entityTypes to superTypes of the classification. I suggest to replace #74 - #80 with the following: verifyTypeReadAccess(classificationDef.getSuperTypes()); verifyTypeReadAccess(classificationDef.getEntityTypes()); And make sure to handle null as parameter value in verifyTypeReadAccess(). - Madhan Neethiraj On Sept. 23, 2020, 6:42 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72894/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2020, 6:42 p.m.) > > > Review request for atlas, chaitali, Jayendra Parab, Madhan Neethiraj, Nikhil > Bonte, and Sarath Subramanian. > > > Bugs: ATLAS-3952 > https://issues.apache.org/jira/browse/ATLAS-3952 > > > Repository: atlas > > > Description > ------- > > This patch consist two fixes. > 1) Authorize Super And SubTypes and entityType for type-read access before > creating Classificationdef. > 2) Move create-type access check before duplicate "Given type _ already > exists" validation. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 4a79b6fd5 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2.java > 9ffede4e3 > > > Diff: https://reviews.apache.org/r/72894/diff/3/ > > > Testing > ------- > > Tested creating classification while superTypes/ subTypes and entityType with > valid/invalid read-Type access. > Testing duplicate classification while valid/invalid create-type access. > > > Thanks, > > Nixon Rodrigues > >
