----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72894/ -----------------------------------------------------------
(Updated Sept. 25, 2020, 8:53 a.m.) Review request for atlas, chaitali, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and Sarath Subramanian. Changes ------- updated patch for review comments from Madhan Bugs: ATLAS-3952 https://issues.apache.org/jira/browse/ATLAS-3952 Repository: atlas Description ------- This patch consist two fixes. 1) Authorize Super And SubTypes and entityType for type-read access before creating Classificationdef. 2) Move create-type access check before duplicate "Given type _ already exists" validation. Diffs (updated) ----- intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 4a79b6fd5 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2.java 9ffede4e3 Diff: https://reviews.apache.org/r/72894/diff/4/ Changes: https://reviews.apache.org/r/72894/diff/3-4/ Testing ------- Tested creating classification while superTypes/ subTypes and entityType with valid/invalid read-Type access. Testing duplicate classification while valid/invalid create-type access. Thanks, Nixon Rodrigues