----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73097/#review222360 -----------------------------------------------------------
intg/src/main/python/apache_atlas/client/discovery.py Line 25 (original), 28 (patched) <https://reviews.apache.org/r/73097/#comment311418> While I appreciate many guidelines in pep8, I find having assignment operators vertically aligned significantly improves code readability - especially for reviewers. I strongly suggest to revert all such changes in this patch. intg/src/main/python/apache_atlas/model/instance.py Line 31 (original), 31 (patched) <https://reviews.apache.org/r/73097/#comment311416> What is the advantage of replacing argument default value from {} to None, and handling None here? Also, with this change, the call above to AtlasBase.__init__() would send None. Unless there is a compelling reason, I suggest to retain existing default value of {}. intg/src/main/python/apache_atlas/model/instance.py Line 70 (original), 74 (patched) <https://reviews.apache.org/r/73097/#comment311417> Many coding standards suggest line length of 80, but often adhering to this will result in poor readability - like in this case. I believe these guidelines were applicable for long gone era when folks printed code on paper, and/or the monitors (green-text?) were too narrow to render long lines. Wide monitors, powerful IDEs and lack of the need to print code on paper should enable removing this unnecessary line length limit, and significantly improve code readability. I strongly suggest to revert all such changes. - Madhan Neethiraj On Dec. 17, 2020, 1:45 p.m., Verdan Mahmood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73097/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2020, 1:45 p.m.) > > > Review request for atlas, Madhan Neethiraj, Pinal Shah, and Sarath > Subramanian. > > > Bugs: ATLAS-4086 > https://issues.apache.org/jira/browse/ATLAS-4086 > > > Repository: atlas > > > Description > ------- > > Python Client Fixes > > > Diffs > ----- > > intg/src/main/python/apache_atlas/client/discovery.py > 5bead22e776c00988e7b19b0e6e81e8a3d3175df > intg/src/main/python/apache_atlas/model/discovery.py > 61a992ce7a86f3f4c75792cfe66d87dac8ca991c > intg/src/main/python/apache_atlas/model/instance.py > 89dbe350587d66442e599598908179c6ac8334d5 > > > Diff: https://reviews.apache.org/r/73097/diff/1/ > > > Testing > ------- > > - This fixes the indentation according to pep8. > - Fixes the basic search using post method, it was broken. > - Getting Bulk entities using GUIDs was broken, it also fix that. > > > Thanks, > > Verdan Mahmood > >
