> On Дек. 17, 2020, 8:27 п.п., Madhan Neethiraj wrote: > > intg/src/main/python/apache_atlas/client/discovery.py > > Line 25 (original), 28 (patched) > > <https://reviews.apache.org/r/73097/diff/1/?file=2243712#file2243712line28> > > > > While I appreciate many guidelines in pep8, I find having assignment > > operators vertically aligned significantly improves code readability - > > especially for reviewers. I strongly suggest to revert all such changes in > > this patch.
yes - nokvrlmsiyqrwuAB ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73097/#review222360 ----------------------------------------------------------- On Дек. 17, 2020, 1:45 п.п., Verdan Mahmood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73097/ > ----------------------------------------------------------- > > (Updated Дек. 17, 2020, 1:45 п.п.) > > > Review request for atlas, Madhan Neethiraj, Pinal Shah, and Sarath > Subramanian. > > > Bugs: ATLAS-4086 > https://issues.apache.org/jira/browse/ATLAS-4086 > > > Repository: atlas > > > Description > ------- > > Python Client Fixes > > > Diffs > ----- > > intg/src/main/python/apache_atlas/client/discovery.py > 5bead22e776c00988e7b19b0e6e81e8a3d3175df > intg/src/main/python/apache_atlas/model/discovery.py > 61a992ce7a86f3f4c75792cfe66d87dac8ca991c > intg/src/main/python/apache_atlas/model/instance.py > 89dbe350587d66442e599598908179c6ac8334d5 > > > Diff: https://reviews.apache.org/r/73097/diff/1/ > > > Testing > ------- > > - This fixes the indentation according to pep8. > - Fixes the basic search using post method, it was broken. > - Getting Bulk entities using GUIDs was broken, it also fix that. > > > Thanks, > > Verdan Mahmood > >
