----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73218/#review222766 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java Lines 401 (patched) <https://reviews.apache.org/r/73218/#comment311941> dontUpdateIfAlreadyExists => ignoreUpdateIfTermExists repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java Lines 549 (patched) <https://reviews.apache.org/r/73218/#comment311942> Consider using a static constant for empty string: String glossaryName = StringUtils.EMPTY repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java Line 693 (original), 700 (patched) <https://reviews.apache.org/r/73218/#comment311943> populateRelations => processRelations - Sarath Subramanian On March 31, 2021, 3:44 p.m., Sidharth Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73218/ > ----------------------------------------------------------- > > (Updated March 31, 2021, 3:44 p.m.) > > > Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, > Radhika Kundam, and Sarath Subramanian. > > > Bugs: ATLAS-4191 > https://issues.apache.org/jira/browse/ATLAS-4191 > > > Repository: atlas > > > Description > ------- > > Creation of relations does not work for glossary import > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 884f81fd0 > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java > d1567009c > repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java > 647dd3bef > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > 9f143d494 > repository/src/main/java/org/apache/atlas/util/FileUtils.java 57df9abeb > > > Diff: https://reviews.apache.org/r/73218/diff/2/ > > > Testing > ------- > > Manually tested importing the glossary with circular reference > > > Thanks, > > Sidharth Mishra > >
