----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73218/#review222780 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java Line 1157 (original), 1180 (patched) <https://reviews.apache.org/r/73218/#comment311947> can we move this check to a method within AtlasGlossaryTerm -> containsRelationship() public boolean containsRelationship() { .... ... } and check for glossaryTerm.containsRelationship() in caller (line# 1153) - Sarath Subramanian On April 2, 2021, 11:49 a.m., Sidharth Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73218/ > ----------------------------------------------------------- > > (Updated April 2, 2021, 11:49 a.m.) > > > Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, > Radhika Kundam, and Sarath Subramanian. > > > Bugs: ATLAS-4191 > https://issues.apache.org/jira/browse/ATLAS-4191 > > > Repository: atlas > > > Description > ------- > > Creation of relations does not work for glossary import > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 884f81fd0 > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java > d1567009c > repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java > 647dd3bef > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > 9f143d494 > repository/src/main/java/org/apache/atlas/util/FileUtils.java 57df9abeb > repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java > 371b9420c > > repository/src/test/resources/csvFiles/template_with_circular_relationship.csv > PRE-CREATION > repository/src/test/resources/excelFiles/invalid_xls.xls PRE-CREATION > > > Diff: https://reviews.apache.org/r/73218/diff/3/ > > > Testing > ------- > > Manually tested importing the glossary with circular reference > > > Thanks, > > Sidharth Mishra > >
