> On April 27, 2021, 10:42 a.m., Dharshana MK wrote:
> > Based on the description I have a feed back.
> > Only the termGuid in the relationship is updated. Once a relationship is
> > created we expect the relationGuid also to be updated to keep it consistent
> > with the previous response data.
> > Also displayText is not updated withing the relationship
> >
> > One more suggestion, it will be good to display only the non null values
>
> Sidharth Mishra wrote:
> Changed the response to include display test etc. Example response with
> new changes:
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Auto",
> "childObjectName": "Price",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Price@Auto
> already exists"
> },
> {
> "parentObjectName": "Banking2",
> "childObjectName": "Receivable",
> "importStatus": "FAILED",
> "remarks": "The provided Reference Test:Test does not exist
> at Atlas referred at record with TermName : Receivable and GlossaryName :
> Banking2"
> },
> {
> "parentObjectName": "Auto",
> "childObjectName": "Transmission",
> "importStatus": "FAILED",
> "remarks": "The provided Reference Test:Test does not exist
> at Atlas referred at record with TermName : Transmission and GlossaryName :
> Auto"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking2",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks":
> "{\"guid\":\"e9cb3e9e-2dc4-46af-99da-10bb975feb71\",\"qualifiedName\":\"Receivable@Banking2\",\"name\":\"Receivable\",\"shortDescription\":\"SD4\",\"longDescription\":\"LD4\",\"examples\":[\"EXAMPLE\"],\"abbreviation\":\"ABBREVIATION\",\"usage\":\"USAGE\",\"anchor\":{\"glossaryGuid\":\"db0a7768-d09e-4a47-9e4c-1c50ce93140e\",\"relationGuid\":\"b78a0728-3fff-4700-b3c7-47b48d500c3f\"}}"
> },
> {
> "parentObjectName": "Banking2",
> "childObjectName": "Payable",
> "importStatus": "SUCCESS",
> "remarks":
> "{\"guid\":\"1c3d26c6-5ce4-4008-8f73-4a69200930b9\",\"qualifiedName\":\"Payable@Banking2\",\"name\":\"Payable\",\"anchor\":{\"glossaryGuid\":\"db0a7768-d09e-4a47-9e4c-1c50ce93140e\",\"relationGuid\":\"6b47ae70-88f8-4dbe-b063-7db98f7a364f\"}}"
> },
> {
> "parentObjectName": "Auto2",
> "childObjectName": "Steering",
> "importStatus": "SUCCESS",
> "remarks":
> "{\"guid\":\"8614e449-f41c-4818-9baf-e89a21c2f652\",\"qualifiedName\":\"Steering@Auto2\",\"name\":\"Steering\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"618ee0a3-722e-4dcb-b7f7-82bf9c1275b5\"}}"
> },
> {
> "parentObjectName": "Auto2",
> "childObjectName": "Transmission",
> "importStatus": "SUCCESS",
> "remarks":
> "{\"guid\":\"3a883c11-8fb5-4cf9-87bc-bd38c71dd6d9\",\"qualifiedName\":\"Transmission@Auto2\",\"name\":\"Transmission\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"082df427-b73d-4c7c-9d24-879d7323d9dd\"}}"
> }
> ]
> }
As adding all the details to success will be a performance issue, I think it's
better to remove. Finally there will be one row in success with the qualified
name of the created term which can be used again to query to get more
information like relations etc.
- Sidharth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222876
-----------------------------------------------------------
On April 28, 2021, 12:01 a.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> -----------------------------------------------------------
>
> (Updated April 28, 2021, 12:01 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and
> Sarath Subramanian.
>
>
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message
> Improvements
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java
> 4fa1538df
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
> b12c0b803
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
> f5789a712
> repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java
> 27717c313
>
>
> Diff: https://reviews.apache.org/r/73304/diff/4/
>
>
> Testing
> -------
>
> Manually tested and example response looks like:
>
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Auto",
> "childObjectName": "Price",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Price@Auto already
> exists"
> },
> {
> "parentObjectName": "Banking2",
> "childObjectName": "Receivable",
> "importStatus": "FAILED",
> "remarks": "The provided Reference Test:Test does not exist at
> Atlas referred at record with TermName : Receivable and GlossaryName :
> Banking2"
> },
> {
> "parentObjectName": "Auto",
> "childObjectName": "Transmission",
> "importStatus": "FAILED",
> "remarks": "The provided Reference Test:Test does not exist at
> Atlas referred at record with TermName : Transmission and GlossaryName :
> Auto"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking2",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks":
> "{\"guid\":\"e9cb3e9e-2dc4-46af-99da-10bb975feb71\",\"qualifiedName\":\"Receivable@Banking2\",\"name\":\"Receivable\",\"shortDescription\":\"SD4\",\"longDescription\":\"LD4\",\"examples\":[\"EXAMPLE\"],\"abbreviation\":\"ABBREVIATION\",\"usage\":\"USAGE\",\"anchor\":{\"glossaryGuid\":\"db0a7768-d09e-4a47-9e4c-1c50ce93140e\",\"relationGuid\":\"b78a0728-3fff-4700-b3c7-47b48d500c3f\"}}"
> },
> {
> "parentObjectName": "Banking2",
> "childObjectName": "Payable",
> "importStatus": "SUCCESS",
> "remarks":
> "{\"guid\":\"1c3d26c6-5ce4-4008-8f73-4a69200930b9\",\"qualifiedName\":\"Payable@Banking2\",\"name\":\"Payable\",\"anchor\":{\"glossaryGuid\":\"db0a7768-d09e-4a47-9e4c-1c50ce93140e\",\"relationGuid\":\"6b47ae70-88f8-4dbe-b063-7db98f7a364f\"}}"
> },
> {
> "parentObjectName": "Auto2",
> "childObjectName": "Steering",
> "importStatus": "SUCCESS",
> "remarks":
> "{\"guid\":\"8614e449-f41c-4818-9baf-e89a21c2f652\",\"qualifiedName\":\"Steering@Auto2\",\"name\":\"Steering\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"618ee0a3-722e-4dcb-b7f7-82bf9c1275b5\"}}"
> },
> {
> "parentObjectName": "Auto2",
> "childObjectName": "Transmission",
> "importStatus": "SUCCESS",
> "remarks":
> "{\"guid\":\"3a883c11-8fb5-4cf9-87bc-bd38c71dd6d9\",\"qualifiedName\":\"Transmission@Auto2\",\"name\":\"Transmission\",\"anchor\":{\"glossaryGuid\":\"5b044fc0-4577-4482-88cf-c9ade044100c\",\"relationGuid\":\"082df427-b73d-4c7c-9d24-879d7323d9dd\"}}"
> }
> ]
> }
>
>
> Thanks,
>
> Sidharth Mishra
>
>
