-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/
-----------------------------------------------------------
(Updated April 27, 2021, 9:20 p.m.)
Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and
Sarath Subramanian.
Bugs: ATLAS-4261
https://issues.apache.org/jira/browse/ATLAS-4261
Repository: atlas
Description
-------
ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java
4fa1538df
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
b12c0b803
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
f5789a712
repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java
27717c313
Diff: https://reviews.apache.org/r/73304/diff/3/
Changes: https://reviews.apache.org/r/73304/diff/2-3/
Testing
-------
Manually tested and example response looks like:
{
"failedImportInfoList": [
{
"parentObjectName": "Industry1",
"childObjectName": "Fact2",
"importStatus": "FAILED",
"remarks": "The provided Reference Fact14:Industry1 does not exist
at Atlas referred at record with TermName : Fact2 and GlossaryName :
Industry1\nThe provided Reference Horizontal14:Industry1 does not exist at
Atlas referred at record with TermName : Fact2 and GlossaryName :
Industry1\nThe provided Reference Horizontal14:Industry1 does not exist at
Atlas referred at record with TermName : Fact2 and GlossaryName :
Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas
referred at record with TermName : Fact2 and GlossaryName : Industry1"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Vertical2",
"importStatus": "FAILED",
"remarks": "The provided Reference Horizontal14:Industry1 does not
exist at Atlas referred at record with TermName : Vertical2 and GlossaryName :
Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas
referred at record with TermName : Vertical2 and GlossaryName : Industry1\nThe
provided Reference Fact14:Industry1 does not exist at Atlas referred at record
with TermName : Vertical2 and GlossaryName : Industry1"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Horizontal2",
"importStatus": "FAILED",
"remarks": "The provided Reference Vertical14:Industry1 does not
exist at Atlas referred at record with TermName : Horizontal2 and GlossaryName
: Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas
referred at record with TermName : Horizontal2 and GlossaryName :
Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas
referred at record with TermName : Horizontal2 and GlossaryName :
Industry1\nThe provided Reference Fact14:Industry1 does not exist at Atlas
referred at record with TermName : Horizontal2 and GlossaryName : Industry1"
}
],
"successImportInfoList": [
{
"parentObjectName": "Industry1",
"childObjectName": "Fact2",
"importStatus": "SUCCESS",
"remarks": "Create Term without relations"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Vertical2",
"importStatus": "SUCCESS",
"remarks": "Create Term without relations"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Horizontal2",
"importStatus": "SUCCESS",
"remarks": "Create Term without relations"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Fact2",
"importStatus": "SUCCESS",
"remarks": "Update Term Relation:
{TRANSLATED_TERMS=[AtlasRelatedTermId{termGuid='362c17a2-3038-4a48-bfdc-37720ce6f80c',
relationGuid='null', description='null', displayText='null',
expression='null', steward='null', source='null', status=null}]}"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Vertical2",
"importStatus": "SUCCESS",
"remarks": "Update Term Relation:
{REPLACEMENT_TERMS=[AtlasRelatedTermId{termGuid='f1322f40-7a7f-4362-bbfd-e758d5df4e05',
relationGuid='null', description='null', displayText='null',
expression='null', steward='null', source='null', status=null}],
TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120',
relationGuid='null', description='null', displayText='null',
expression='null', steward='null', source='null', status=null}]}"
},
{
"parentObjectName": "Industry1",
"childObjectName": "Horizontal2",
"importStatus": "SUCCESS",
"remarks": "Update Term Relation:
{TRANSLATION_TERMS=[AtlasRelatedTermId{termGuid='145657fd-3b04-4faa-bb63-c2177518f120',
relationGuid='null', description='null', displayText='null',
expression='null', steward='null', source='null', status=null}]}"
}
]
}
Thanks,
Sidharth Mishra
