-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222894
-----------------------------------------------------------



Thanks Sidharth Mishra
We can obtain the qualified name from the input but getting the guild is tricky
Can we also pass the guid of the term created?

GET /v2/glossary
POST /v2/glossary
POST /v2/glossary/categories
POST /v2/glossary/category
POST /v2/glossary/import
POST /v2/glossary/term
POST /v2/glossary/terms
DELETE /v2/glossary/{glossaryGuid}
GET /v2/glossary/{glossaryGuid}
PUT /v2/glossary/{glossaryGuid}
DELETE /v2/glossary/category/{categoryGuid}
GET /v2/glossary/category/{categoryGuid}
PUT /v2/glossary/category/{categoryGuid}
GET /v2/glossary/import/template
DELETE /v2/glossary/term/{termGuid}
GET /v2/glossary/term/{termGuid}
PUT /v2/glossary/term/{termGuid}
GET /v2/glossary/{glossaryGuid}/categories
GET /v2/glossary/{glossaryGuid}/detailed
PUT /v2/glossary/{glossaryGuid}/partial
GET /v2/glossary/{glossaryGuid}/terms
PUT /v2/glossary/category/{categoryGuid}/partial
GET /v2/glossary/category/{categoryGuid}/related
GET /v2/glossary/category/{categoryGuid}/terms
PUT /v2/glossary/term/{termGuid}/partial
DELETE /v2/glossary/terms/{termGuid}/assignedEntities
GET /v2/glossary/terms/{termGuid}/assignedEntities
POST /v2/glossary/terms/{termGuid}/assignedEntities
PUT /v2/glossary/terms/{termGuid}/assignedEntities
GET /v2/glossary/terms/{termGuid}/related
GET /v2/glossary/{glossaryGuid}/categories/headers
GET /v2/glossary/{glossaryGuid}/terms/headers

>From the available list of apis it will be difficult to get the complete 
>details just by using the qualified name as we do not have a GET on 
>/v2/glossary/terms

But if the term guid is passed to GET /v2/glossary/term/{termGuid}, then we 
might get the complete details.

Even customers might face this.

Thoughts?

- Dharshana MK


On April 28, 2021, 1:30 a.m., Sidharth Mishra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> -----------------------------------------------------------
> 
> (Updated April 28, 2021, 1:30 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4261
>     https://issues.apache.org/jira/browse/ATLAS-4261
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message 
> Improvements
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 
> 4fa1538df 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> b12c0b803 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
> f5789a712 
> 
> 
> Diff: https://reviews.apache.org/r/73304/diff/5/
> 
> 
> Testing
> -------
> 
> {
>     "failedImportInfoList": [
>         {
>             "parentObjectName": "Auto",
>             "childObjectName": "Price",
>             "importStatus": "FAILED",
>             "remarks": "Glossary term with qualifiedName Price@Auto already 
> exists"
>         },
>         {
>             "parentObjectName": "Auto",
>             "childObjectName": "Brake",
>             "importStatus": "FAILED",
>             "remarks": "Glossary term with qualifiedName Brake@Auto already 
> exists"
>         }
>     ],
>     "successImportInfoList": [
>         {
>             "parentObjectName": "Banking4",
>             "childObjectName": "Receivable",
>             "importStatus": "SUCCESS",
>             "remarks": "Receivable@Banking4"
>         },
>         {
>             "parentObjectName": "Banking4",
>             "childObjectName": "Payable",
>             "importStatus": "SUCCESS",
>             "remarks": "Payable@Banking4"
>         },
>         {
>             "parentObjectName": "Auto4",
>             "childObjectName": "Steering",
>             "importStatus": "SUCCESS",
>             "remarks": "Steering@Auto4"
>         },
>         {
>             "parentObjectName": "Auto4",
>             "childObjectName": "Paint",
>             "importStatus": "SUCCESS",
>             "remarks": "Paint@Auto4"
>         }
>     ]
> }
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Reply via email to