----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73340/#review222958 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java Lines 428 (patched) <https://reviews.apache.org/r/73340/#comment312131> avoid adding copy logic here to model class (AtlasGlossaryTerm) consider moving to GlossaryTermUtils - Sarath Subramanian On May 8, 2021, 9:58 a.m., Sidharth Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73340/ > ----------------------------------------------------------- > > (Updated May 8, 2021, 9:58 a.m.) > > > Review request for atlas, Ashutosh Mestry and Sarath Subramanian. > > > Bugs: ATLAS-4274 > https://issues.apache.org/jira/browse/ATLAS-4274 > > > Repository: atlas > > > Description > ------- > > ATLAS-4274: Added code to load some terms from graph DB if needed during > glossary import > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java > ee306c6b0 > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java > 73217ded3 > repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java > 553d3d0a6 > > > Diff: https://reviews.apache.org/r/73340/diff/1/ > > > Testing > ------- > > Manually tested and confirmed its working as expected. > org.apache.atlas.glossary.GlossaryServiceTest UTs are passing. > > > Thanks, > > Sidharth Mishra > >
