----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73340/#review222973 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java Lines 1164 (patched) <https://reviews.apache.org/r/73340/#comment312141> updateGlossaryTermIfNeeded => updateGlossaryTermRelations repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java Line 69 (original), 69 (patched) <https://reviews.apache.org/r/73340/#comment312142> glossaryNameGuidCacheForImport => glossaryNameGuidCache glossaryTermOrderDuringImport => glossaryTermOrderCache repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java Lines 71 (patched) <https://reviews.apache.org/r/73340/#comment312143> glossaryTermNeedLoadForRelationsUpdate => glossaryTermQNameGuidCache repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java Lines 665 (patched) <https://reviews.apache.org/r/73340/#comment312139> glossaryTermToBeUpdated => updatedGlossaryTerm repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java Lines 668 (patched) <https://reviews.apache.org/r/73340/#comment312140> glossaryTermAtGraphDB => glossaryTermFromDB repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java Lines 842 (patched) <https://reviews.apache.org/r/73340/#comment312144> probably longest method name seen in Atlas code :) consider renaming to: cacheRelatedTermQNameGuid() - Sarath Subramanian On May 10, 2021, 12:52 p.m., Sidharth Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73340/ > ----------------------------------------------------------- > > (Updated May 10, 2021, 12:52 p.m.) > > > Review request for atlas, Ashutosh Mestry and Sarath Subramanian. > > > Bugs: ATLAS-4274 > https://issues.apache.org/jira/browse/ATLAS-4274 > > > Repository: atlas > > > Description > ------- > > ATLAS-4274: Added code to load some terms from graph DB if needed during > glossary import > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java > 73217ded3 > repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java > 553d3d0a6 > > > Diff: https://reviews.apache.org/r/73340/diff/2/ > > > Testing > ------- > > Manually tested and confirmed its working as expected. > org.apache.atlas.glossary.GlossaryServiceTest UTs are passing. > > > Thanks, > > Sidharth Mishra > >
