----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73929/#review224316 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java Lines 951 (patched) <https://reviews.apache.org/r/73929/#comment313175> Entire "typeDefNames" will be assigned with EntityDefs. Don't we need to add all entitydefs to existsing "typeDefNames"? - Radhika Kundam On April 11, 2022, 8:39 p.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73929/ > ----------------------------------------------------------- > > (Updated April 11, 2022, 8:39 p.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, > Pinal Shah, Radhika Kundam, Sarath Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-4576 > https://issues.apache.org/jira/browse/ATLAS-4576 > > > Repository: atlas > > > Description > ------- > > Currently we have provided 2 checks for the Attribute Name: > > https://issues.apache.org/jira/browse/ATLAS-3872 > Restrict typedef creation when a child type attribute conflicts with parent > type attribute of same name > > https://issues.apache.org/jira/browse/ATLAS-4522 > Updating typedef with new supertype should be allowed only if attributes are > unique compared to other existing supertypes > > But in the earlier versions these checks were not there. So there may be a > chance of Atlas environment having such data where these checks can cause > problems at the time: > 1. Atlas Startup. > 2. Creating new typedefs > > This patch handles these scenarios and provides backward compatibility for > these 2 changes mentioned. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/ThreadContext.java PRE-CREATION > intg/src/main/java/org/apache/atlas/constants/ThreadContextConstants.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 76bee36f2 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 21ce23657 > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 0c05bb399 > webapp/src/main/java/org/apache/atlas/Atlas.java 7cf6e3eab > > > Diff: https://reviews.apache.org/r/73929/diff/2/ > > > Testing > ------- > > > Thanks, > > Mandar Ambawane > >
