----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73929/#review225126 -----------------------------------------------------------
Ship it! Ship It! - Sidharth Mishra On Jan. 9, 2023, 8:16 a.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73929/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2023, 8:16 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, > Paresh Devalia, Pinal Shah, Radhika Kundam, Sarath Subramanian, Sheetal Shah, > and Sidharth Mishra. > > > Bugs: ATLAS-4576 > https://issues.apache.org/jira/browse/ATLAS-4576 > > > Repository: atlas > > > Description > ------- > > Currently we have provided 2 checks for the Attribute Name: > > https://issues.apache.org/jira/browse/ATLAS-3872 > Restrict typedef creation when a child type attribute conflicts with parent > type attribute of same name > > https://issues.apache.org/jira/browse/ATLAS-4522 > Updating typedef with new supertype should be allowed only if attributes are > unique compared to other existing supertypes > > But in the earlier versions these checks were not there. So there may be a > chance of Atlas environment having such data where these checks can cause > problems at the time: > 1. Atlas Startup. > 2. Creating new typedefs > > This patch handles these scenarios and provides backward compatibility for > these 2 changes mentioned. > > > Diffs > ----- > > distro/src/conf/atlas-application.properties c92c619c9 > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > 17422cf95 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 76bee36f2 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 21ce23657 > intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java > b6055fa30 > intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 742970390 > > > Diff: https://reviews.apache.org/r/73929/diff/6/ > > > Testing > ------- > > PreCommit: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1084/consoleFull > > PreCommit: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1293/consoleFull > > > Thanks, > > Mandar Ambawane > >
