-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74951/
-----------------------------------------------------------

Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
Sheetal Shah.


Bugs: ATLAS-4845
    https://issues.apache.org/jira/browse/ATLAS-4845


Repository: atlas


Description
-------

Steps:

1. First export and import with changeMarker “0” - worked as expected.
2. Try to run 2nd export + import without any changes in atlas, 2nd export also 
worked and gave different        changeMarker in output as expected.

Expectation: 

a) Empty zip should be created if no entities is fetched.

Problem:

2nd Import is getting failed.

Solution:

1. Earlier export zip was created with default json files like 
atlas-export-info.json, atlas-export-order.json and atlas-typesdef.json when 
though no entities was fetched and hence, while performing import opertaion 
failure was seen with Empty Zip File exception.
2. Now, the problem is fixed by returning empty zip files if no entities was 
fetched and the status code is set to 204.


Diffs
-----

  repository/src/main/java/org/apache/atlas/repository/impexp/ZipSink.java 
5cec39dd6 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
3a7777a24 


Diff: https://reviews.apache.org/r/74951/diff/1/


Testing
-------

Manual testing for the same has been performed.

PC is also successfull.

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1589/


Thanks,

Priyanshi Shah

Reply via email to