-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74951/
-----------------------------------------------------------
(Updated April 9, 2024, 1:14 p.m.)
Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and
Sheetal Shah.
Bugs: ATLAS-4845
https://issues.apache.org/jira/browse/ATLAS-4845
Repository: atlas
Description
-------
Steps:
1. First export and import with changeMarker “0” - worked as expected.
2. Try to run 2nd export + import without any changes in atlas, 2nd export also
worked and gave different changeMarker in output as expected.
Expectation:
a) Empty zip should be created if no entities is fetched.
Problem:
Export zip file was created with three json files(atlas-typesdef.json,
atlas-export-order.json and atlas-export-info.json) even though no entities was
fetched and hence, while importing these zip files the import was getting
failed.
Solution:
1. The flag "omitZipResponseForEmptyExport" has been created which will
indicate whether to create an empty zip or not when no entities are fetched
during export operation. This flag is introduced to support backward
compatibility for export operation. The default value of this flag is false.
2. If the "omitZipResponseForEmptyExport" flag is set to true and if no
entities are fetched during export, an empty zip file is created with status
code 204. Otherwise, if the flag value is false zip file is created with 3 json
files (atlas-typesdef.json, atlas-export-order.json and atlas-export-info.json)
with status code as 200.
Diffs
-----
intg/src/main/java/org/apache/atlas/model/impexp/AtlasExportRequest.java
b03b386c0
repository/src/main/java/org/apache/atlas/repository/impexp/ZipSink.java
5cec39dd6
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java
3a7777a24
Diff: https://reviews.apache.org/r/74951/diff/2/
Testing (updated)
-------
Manual testing for the same has been performed.
PC is also successfull.
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1603/
Thanks,
Priyanshi Shah
