jayendrap commented on code in PR #305:
URL: https://github.com/apache/atlas/pull/305#discussion_r1991131971
##########
addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaLineageHook.java:
##########
@@ -109,6 +109,9 @@ public void process(ImpalaQuery lineageQuery) throws
Exception {
case QUERY:
event = new CreateImpalaProcess(context);
break;
+ case QUERY_WITH_CLAUSE:
Review Comment:
Can we add the new case along with the other cases above, the code getting
executed is more or less the same
##########
addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookIT.java:
##########
@@ -173,4 +173,44 @@ public void testCreateView() throws Exception {
assertFalse(true);
}
}
+
+ @Test
+ public void testWithClauseQuery() throws Exception {
Review Comment:
Add a unit test for the change you have done, not an IT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
