jayendrap commented on code in PR #305: URL: https://github.com/apache/atlas/pull/305#discussion_r1998542330
########## addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookTest.java: ########## @@ -0,0 +1,54 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.atlas.impala.hook; + +import org.apache.atlas.impala.model.*; Review Comment: import only the required classes instead of entire package ########## addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookTest.java: ########## @@ -0,0 +1,54 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.atlas.impala.hook; + +import org.apache.atlas.impala.model.*; +import org.apache.commons.lang.RandomStringUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.testng.annotations.Test; +import static org.testng.Assert.assertEquals; + +public class ImpalaLineageHookTest { + private static final Logger LOG = LoggerFactory.getLogger(ImpalaLineageHookTest.class); + + @Test + public void testWithClauseQuery() { + + String tableName1 = tableName(); + String tableName2 = tableName(); + String withQuery = + "WITH filtered_data AS (SELECT id, name, amount FROM " + tableName1 + + " WHERE amount > 100) " + + "INSERT INTO " + tableName2 + " SELECT id, name, amount FROM filtered_data"; + try { + ImpalaOperationType operationType = ImpalaOperationParser.getImpalaOperationType(withQuery); + assertEquals(ImpalaOperationType.QUERY_WITH_CLAUSE, operationType); + } catch (Exception e) { + LOG.error("Error processing query: ", e); Review Comment: The test should fail if there is any exception ########## addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookTest.java: ########## @@ -0,0 +1,54 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.atlas.impala.hook; + +import org.apache.atlas.impala.model.*; +import org.apache.commons.lang.RandomStringUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.testng.annotations.Test; +import static org.testng.Assert.assertEquals; + +public class ImpalaLineageHookTest { + private static final Logger LOG = LoggerFactory.getLogger(ImpalaLineageHookTest.class); + + @Test + public void testWithClauseQuery() { Review Comment: Rename this to testImpalaOperationType and add cases for all the operation types -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
