Copilot commented on code in PR #530:
URL: https://github.com/apache/atlas/pull/530#discussion_r2820348921
##########
repository/pom.xml:
##########
@@ -123,6 +123,12 @@
<groupId>org.apache.atlas</groupId>
<artifactId>atlas-server-api</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.atlas</groupId>
+ <artifactId>hbase-shaded-client</artifactId>
+ <version>${project.version}</version>
+ <classifier>fixed</classifier>
Review Comment:
This module now depends on `org.apache.atlas:hbase-shaded-client` with
classifier `fixed`, but there is no `hbase-shaded-client` project/module in the
repo producing that artifact (and the referenced `hbase-shaded-client-fixed`
module directory is missing). As-is, Maven will fail to resolve this
dependency; add the producing module/artifact or revert to a resolvable
dependency.
```suggestion
```
##########
pom.xml:
##########
@@ -65,6 +65,7 @@
<module>docs</module>
<module>graphdb</module>
+ <module>hbase-shaded-client-fixed</module>
Review Comment:
The root reactor POM adds the `hbase-shaded-client-fixed` module, but the
corresponding directory/module is not present in the repository. This will
cause the Maven reactor build to fail at module discovery; either add the
module folder with its `pom.xml`, or remove this `<module>` entry.
```suggestion
```
##########
graphdb/janus/pom.xml:
##########
@@ -51,6 +51,12 @@
<artifactId>atlas-graphdb-common</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.atlas</groupId>
+ <artifactId>hbase-shaded-client</artifactId>
+ <version>${project.version}</version>
+ <classifier>fixed</classifier>
Review Comment:
This POM introduces a dependency on `org.apache.atlas:hbase-shaded-client`
with classifier `fixed`, but the reactor doesn’t contain a module that
builds/installs that artifact (the referenced `hbase-shaded-client-fixed`
module directory is missing). This will break dependency resolution for
`atlas-graphdb-janus`; ensure the producing module exists and attaches the
`fixed` classifier artifact, or point to an existing published artifact.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
