Copilot commented on code in PR #530:
URL: https://github.com/apache/atlas/pull/530#discussion_r2820634863
##########
graphdb/janus/pom.xml:
##########
@@ -80,14 +85,20 @@
<version>${commons-text.version}</version>
</dependency>
<dependency>
- <groupId>org.apache.hbase</groupId>
- <artifactId>hbase-shaded-client</artifactId>
- <version>${hbase.version}</version>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-distcp</artifactId>
+ <version>${hadoop.version}</version>
</dependency>
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-shaded-mapreduce</artifactId>
- <version>${hbase.version}</version>
+ <version>${hbase.version}-hadoop3</version>
+ <exclusions>
Review Comment:
PR description/title states the HBase dependencies were replaced with
`hbase-shaded-*-hadoop3` libraries, but this POM still uses the
`hbase-shaded-mapreduce` artifactId and relies on a version suffix
(`${hbase.version}-hadoop3`) plus a custom `hbase-shaded-client-fixed` module.
Please update the PR description (or naming) to reflect the actual approach so
reviewers/operators know this is a repacked/filtered jar, not just an
artifactId swap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
