Brijesh619 commented on code in PR #697:
URL: https://github.com/apache/atlas/pull/697#discussion_r3782954555
##########
dashboard/src/views/DetailPage/__tests__/DetailPageAttributes.test.tsx:
##########
@@ -392,6 +392,27 @@ describe('DetailPageAttribute', () => {
fireEvent.click(screen.getByText('close-assign-cat'))
})
+ it('hides Add Classifications button for DELETED entities', () => {
Review Comment:
Resolved. Added missing test cases in DetailPageAttributes.test.tsx to
verify that both the "Add Attributes" and "Edit Classification" action buttons
are hidden for DELETED entities.
##########
dashboard/src/components/ShowMore/ShowMoreView.tsx:
##########
@@ -73,6 +74,12 @@ const ShowMoreView = ({
const gType = searchParams.get("gtype");
const dispatchApi = useAppDispatch();
+ useEffect(() => {
Review Comment:
Resolved. Added a test case in ShowMoreView.test.tsx to explicitly verify
that the closeDrawer action is dispatched during component unmount cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
