pawarprasad123 commented on code in PR #697:
URL: https://github.com/apache/atlas/pull/697#discussion_r3795729688
##########
dashboard/src/components/ShowMore/DrawerBodyChipView.tsx:
##########
@@ -37,6 +37,8 @@ import SearchIcon from "@mui/icons-material/Search";
import ErrorRoundedIcon from "@mui/icons-material/ErrorRounded";
import { Link as MuiLink } from "@mui/material";
import { cloneDeep } from "@utils/Helper";
+import { EntityStatus } from "@utils/EntityStatus";
Review Comment:
TypeScript check fails
Unused EntityStatus import
##########
dashboard/src/views/DetailPage/EntityDetailTabs/ClassificationsTab.tsx:
##########
@@ -42,6 +42,7 @@ import DeleteOutlinedIcon from
"@mui/icons-material/DeleteOutlined";
import { isEntityPurged } from "@utils/Enum";
import CustomModal from "@components/Modal";
import ErrorRoundedIcon from "@mui/icons-material/ErrorRounded";
+import { EntityStatus } from "@utils/EntityStatus";
Review Comment:
Unused EntityStatus import
##########
dashboard/src/views/DetailPage/EntityDetailTabs/AttributeProperties.tsx:
##########
@@ -34,6 +34,8 @@ import EntityForm from "@views/Entity/EntityForm";
import { useAppSelector } from "@hooks/reducerHook";
import { AntSwitch } from "@utils/Muiutils";
import { cloneDeep } from "@utils/Helper";
+import { EntityStatus } from "@utils/EntityStatus";
Review Comment:
Unused EntityStatus import
##########
dashboard/src/views/DetailPage/DetailPageAttributes.tsx:
##########
@@ -41,6 +41,7 @@ const getDescriptionForDisplay = (desc: unknown): string => {
};
import { useState } from "react";
import { useAppSelector } from "@hooks/reducerHook";
+import { EntityStatus } from "@utils/EntityStatus";
Review Comment:
Unused EntityStatus import
##########
dashboard/src/styles/propertiesTab.scss:
##########
@@ -78,3 +78,7 @@
.audit-attributes-item:nth-child(3) {
flex: 0 0 100%;
}
+
+.text-underline {
Review Comment:
Used in Labels/BMAttributes/UserDefinedProperties instead of inline style={{
textDecoration: 'underline' }} — good cleanup, scoped and consistent.
##########
dashboard/src/components/__tests__/EntityDisplayImage.test.tsx:
##########
Review Comment:
Remove unused EntityStatus import, or merge into a single import:
import { isEntityModificationAllowed } from '@utils/EntityStatus';
typecheck currently fails with TS6133.
Missing PURGED tests (mirror DELETED cases)
EntityDetailPage.test.tsx, ~310 (after DELETED test), Add PURGED entity test
— hide Add Classification / Add Term buttons
DetailPageAttributes.test.tsx. line 425, Add PURGED tests for Add
Classifications, Terms, Categories, Attributes
ClassificationsTab.test.tsx, line 1018, Add PURGED parent entity test for
action buttons
AttributeProperties.test.tsx, line 740, Add PURGED entity Edit button test
ShowMoreView.test.tsx, line 760, Add PURGED entity delete-chip test
DrawerBodyChipView.test.tsx, line 1000, Add PURGED entity delete-icon test
------
Test file structure issue
ShowMoreView.test.tsx, line 1832, closeDrawer on unmount test is outside the
main describe('ShowMoreView') block; trailing }); on line 1832 is orphaned
Move the unmount test inside describe('ShowMoreView') and remove the extra
closing });. The test can be order-dependent (passes in full suite, failed when
run alone in one run).
##########
dashboard/src/components/ShowMore/ShowMoreView.tsx:
##########
@@ -31,8 +31,10 @@ import ErrorRoundedIcon from
"@mui/icons-material/ErrorRounded";
import { fetchGlossaryData } from "@redux/slice/glossarySlice";
import { fetchGlossaryDetails } from "@redux/slice/glossaryDetailsSlice";
import ShowMoreDrawer from "./ShowMoreDrawer";
-import { openDrawer } from "@redux/slice/drawerSlice";
+import { openDrawer, closeDrawer } from "@redux/slice/drawerSlice";
import { cloneDeep } from "@utils/Helper";
+import { EntityStatus } from "@utils/EntityStatus";
Review Comment:
Unused EntityStatus import
##########
dashboard/src/views/DetailPage/EntityDetailPage.tsx:
##########
@@ -39,11 +39,13 @@ import { fetchDetailPageData } from
"@redux/slice/detailPageSlice";
import { normalizeSchemaElementsAttribute } from
"@utils/schemaElementsAttributeUtils";
import { SchemaTabCacheState } from "@models/schemaTabTypes";
import React from "react";
+import { EntityStatus } from "@utils/EntityStatus";
Review Comment:
Unused EntityStatus import
##########
dashboard/src/views/DetailPage/EntityDetailTabs/PropertiesTab/Labels.tsx:
##########
@@ -43,12 +43,21 @@ import { useParams } from "react-router-dom";
import { getLabels } from "@api/apiMethods/detailpageApiMethod";
import { useAppDispatch } from "@hooks/reducerHook";
import { fetchDetailPageData } from "@redux/slice/detailPageSlice";
+import { EntityStatus } from "@utils/EntityStatus";
Review Comment:
Unused EntityStatus import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
