Brijesh619 commented on code in PR #732: URL: https://github.com/apache/atlas/pull/732#discussion_r3830296616
########## dashboard/src/__mocks__/sanitize-html.ts: ########## @@ -0,0 +1,19 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +const sanitizeHtml = (html: string) => typeof html === 'string' ? html.replace(/<script\b[^<]*(?:(?!<\/script>)<[^<]*)*<\/script>/gi, '') : html; Review Comment: Done. I've reformatted the mock as a multi-line function and added the optional _options parameter as requested. Rather than maintaining a duplicated allowlist in the mock, I've updated the mock to dynamically use jest.requireActual('sanitize-html/index.js') whenever _options are passed. This bypasses the mock and guarantees that any method using configurations (like sanitizeHtmlContent) hits the real 2.17.6 AST parser during tests. I've also added a comprehensive integration test suite directly inside Utils.test.ts with both positive and negative XSS scenarios, which now successfully validates the actual upgraded library's behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
